Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of VideoCapture (without audio) #8

Merged
merged 3 commits into from
Jun 20, 2023
Merged

Implementation of VideoCapture (without audio) #8

merged 3 commits into from
Jun 20, 2023

Conversation

yasith
Copy link
Member

@yasith yasith commented May 11, 2023

  • I couldn't figure out how to properly create an executor using the coroutine scope, so leaving the executor to be the main executor for now.

@yasith yasith requested review from jsaund and temcguir May 11, 2023 19:48
@yasith yasith force-pushed the yasith/imageCapture5 branch 4 times, most recently from 4e9d65f to b608457 Compare June 7, 2023 09:22
Base automatically changed from yasith/imageCapture5 to main June 7, 2023 17:53
@yasith
Implement VideoCapture usecase.
1037100 
Start recording video on a long press on the capture button, stop when released.
@yasith yasith merged commit bda8af0 into main Jun 20, 2023
3 checks passed
@yasith yasith deleted the yasith/videoCapture branch June 20, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kimblebee Kimblebee Kimblebee approved these changes

@jsaund jsaund Awaiting requested review from jsaund

@temcguir temcguir Awaiting requested review from temcguir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yasith @Kimblebee